linux-kernel - Re: [PATCH v8 2/4] sched: Rewrite runnable load and utilization average tracking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKfTPtDfHKuUYLkrmoMP2-LUz__qpNw7=QOymzUucJtUyWu=2A@mail.gmail.com>
Date:	Tue, 26 May 2015 18:06:23 +0200
From:	Vincent Guittot <vincent.guittot@...aro.org>
To:	Yuyang Du <yuyang.du@...el.com>
Cc:	Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Paul Turner <pjt@...gle.com>,
	Benjamin Segall <bsegall@...gle.com>,
	Morten Rasmussen <morten.rasmussen@....com>,
	Dietmar Eggemann <dietmar.eggemann@....com>,
	arjan.van.de.ven@...el.com, Len Brown <len.brown@...el.com>,
	rafael.j.wysocki@...el.com,
	"fengguang.wu@...el.com" <fengguang.wu@...el.com>
Subject: Re: [PATCH v8 2/4] sched: Rewrite runnable load and utilization
 average tracking

On 25 May 2015 at 03:49, Yuyang Du <yuyang.du@...el.com> wrote:
[snip]

>
> @@ -2585,334 +2583,156 @@ static __always_inline int __update_entity_runnable_avg(u64 now, int cpu,
>                 periods = delta / 1024;
>                 delta %= 1024;
>
> -               sa->runnable_avg_sum = decay_load(sa->runnable_avg_sum,
> -                                                 periods + 1);
> -               sa->running_avg_sum = decay_load(sa->running_avg_sum,
> -                                                 periods + 1);
> -               sa->avg_period = decay_load(sa->avg_period,
> -                                                    periods + 1);
> +               sa->load_sum = decay_load(sa->load_sum, periods + 1);
> +               sa->util_sum = decay_load(u64(sa->util_sum), periods + 1);

Hi Yuyang,

Brackets are missing around u64 to cast util_sum


>
>                 /* Efficiently calculate \sum (1..n_period) 1024*y^i */
> -               runnable_contrib = __compute_runnable_contrib(periods);
> -               if (runnable)
> -                       sa->runnable_avg_sum += runnable_contrib;
> +               contrib = __compute_runnable_contrib(periods);
> +               if (weight)

>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/