linux-kernel - RE: [PATCH] staging: comedi: comedi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DC148C5AA1CEBA4E87973D432B1C2D883D46F530@P3PWEX4MB008.ex4.secureserver.net>
Date:	Tue, 26 May 2015 18:32:43 +0000
From:	Hartley Sweeten <HartleyS@...ionengravers.com>
To:	Ian Abbott <abbotti@....co.uk>,
	"driverdev-devel@...uxdriverproject.org" 
	<driverdev-devel@...uxdriverproject.org>
CC:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] staging: comedi: comedi_8254.h: make self-reliant

On Friday, May 22, 2015 10:33 AM, Ian Abbott wrote:
> The Comedi "comedi_8254.h" header file is included by various Comedi
> drivers with timer/counters based on the 8254 chip.  The drivers do not
> compile cleanly if this header file is included first.  It uses pointers
> to the `struct comedi_device`, `struct comedi_subdevice`, and `struct
> comedi_insn` structures in various function prototypes, so declare those
> as incomplete types.  It use the `bool` type, so include
> <linux/types.h>.  It also uses the `__iomem` tag, but that seems to be
> taken care of indirectly by including <linux/types.h>.
>
> Signed-off-by: Ian Abbott <abbotti@....co.uk>

Reviewed-by: H Hartley Sweeten <hsweeten@...ionengravers.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/