[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <5564C878.70101@gmail.com>
Date: Tue, 26 May 2015 21:24:40 +0200
From: Mateusz Kulikowski <mateusz.kulikowski@...il.com>
To: Dan Carpenter <dan.carpenter@...cle.com>
CC: gregkh@...uxfoundation.org, joe@...ches.com,
devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 06/35] staging: rtl8192e: Replace memcmp() with ether_addr_equal_unaligned()
On 25.05.2015 16:03, Dan Carpenter wrote:
> On Thu, May 21, 2015 at 05:53:19PM +0200, Mateusz Kulikowski wrote:
>> Use dedicated macro to compare ethernet addresses in probe_rq_parse().
>>
>> Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@...il.com>
>> ---
>> drivers/staging/rtl8192e/rtllib_softmac.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c
>> index 8689b16..65297a0 100644
>> --- a/drivers/staging/rtl8192e/rtllib_softmac.c
>> +++ b/drivers/staging/rtl8192e/rtllib_softmac.c
>> @@ -1853,7 +1853,8 @@ static short probe_rq_parse(struct rtllib_device *ieee, struct sk_buff *skb,
>> return -1; /* corrupted */
>>
>> bssid_match =
>> - (memcmp(header->addr3, ieee->current_network.bssid, ETH_ALEN) != 0) &&
>> + (!ether_addr_equal_unaligned(header->addr3,
>> + ieee->current_network.bssid)) &&
>
> Isn't this aligned?
Yes, this time it is - my bad sorry - I missed this one.
Regards,
Mateusz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists