linux-kernel - Re: [PATCH] Input:keyboard:samsung-keypad

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150526204133.GA27149@dtor-ws>
Date:	Tue, 26 May 2015 13:41:33 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Shailendra Verma <shailendra.capricorn@...il.com>
Cc:	Jingoo Han <jg1.han@...sung.com>, Ferruh Yigit <fery@...ress.com>,
	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
	Wolfram Sang <wsa@...-dreams.de>, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Input:keyboard:samsung-keypad - Fix for correct return
 type

On Mon, May 25, 2015 at 10:30:04PM +0530, Shailendra Verma wrote:
> The return type of the function samsung_keypad_report() is bool but we are
> returning the unsigned int value.So changing the unsigned int to bool type
> and initializing with false.
> 
> Signed-off-by: Shailendra Verma <shailendra.capricorn@...il.com>
> ---
>  drivers/input/keyboard/samsung-keypad.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/input/keyboard/samsung-keypad.c b/drivers/input/keyboard/samsung-keypad.c
> index 6b9fdf6..44b1ba9 100644
> --- a/drivers/input/keyboard/samsung-keypad.c
> +++ b/drivers/input/keyboard/samsung-keypad.c
> @@ -112,7 +112,7 @@ static bool samsung_keypad_report(struct samsung_keypad *keypad,
>  	struct input_dev *input_dev = keypad->input_dev;
>  	unsigned int changed;
>  	unsigned int pressed;
> -	unsigned int key_down = 0;
> +	bool key_down = false;

No, this causes conversion bool->unsigned int->bool on every iteration
of the loop.

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/