linux-kernel - Re: [PATCH v4 02/35] staging: rtl8192e: Declare ethernet addresses as _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 26 May 2015 14:04:15 -0700
From:	Joe Perches <joe@...ches.com>
To:	Mateusz Kulikowski <mateusz.kulikowski@...il.com>
Cc:	Dan Carpenter <dan.carpenter@...cle.com>,
	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 02/35] staging: rtl8192e: Declare ethernet addresses
 as __aligned(2)

On Tue, 2015-05-26 at 22:25 +0200, Mateusz Kulikowski wrote:
> On 25.05.2015 15:53, Dan Carpenter wrote:
> >> diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
[]
> >> +	static const u8 bMac_Tmp_Addr[ETH_ALEN] __aligned(2) = {
> >> +					0x00, 0xe0, 0x4c, 0x00, 0x00, 0x01
> >> +	};
> > 
> > What's up with the whacky indenting?
> 
> It was proposal from Joe; 

Not quite.  I suggested:

	static const u8 bMac_Tmp_Addr[ETH_ALEN] __aligned(2) = {
		0x00, 0xe0, 0x4c, 0x00, 0x00, 0x01
	};

> perhaps breaking 80-column line would be even better in that case 
> (for sure will be once I remove __aligned)



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/