linux-kernel - Re: [PATCHv2] init/do_mounts: Add create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150527162749.60e3f39da22753b1c011f4a1@linux-foundation.org>
Date:	Wed, 27 May 2015 16:27:49 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Vishnu Pratap Singh <vishnu.ps@...sung.com>
Cc:	paul.gortmaker@...driver.com, snitzer@...hat.com,
	dehrenberg@...omium.org, pavel@....cz, mszeredi@...e.cz,
	linux-kernel@...r.kernel.org, cpgs@...sung.com
Subject: Re: [PATCHv2] init/do_mounts: Add create_dev() failure log

On Tue, 26 May 2015 11:56:58 +0530 Vishnu Pratap Singh <vishnu.ps@...sung.com> wrote:

> if create_dev() function fails to create the root mount device (/dev/root),
> then it goes to panic as root device not found but there is no check/log
> present in case of failure, So i have added the log in case it fails to
> create the root device. It will help in debugging.
> 
> ...
>
> --- a/init/do_mounts.c
> +++ b/init/do_mounts.c
> @@ -532,7 +532,8 @@ void __init mount_root(void)
>  	}
>  #endif
>  #ifdef CONFIG_BLOCK
> -	create_dev("/dev/root", ROOT_DEV);
> +	if (create_dev("/dev/root", ROOT_DEV) < 0)
> +		pr_err("Failed to create %s device !\n", "/dev/root");

That's a pretty strange use of printk.

And KERN_EMERG seems more appropriate when this happens.

And we may as well let the poor user know why the mknod failed.

This?

--- a/init/do_mounts.c~init-do_mounts-add-create_dev-failure-log-fix
+++ a/init/do_mounts.c
@@ -533,9 +533,13 @@ void __init mount_root(void)
 	}
 #endif
 #ifdef CONFIG_BLOCK
-	if (create_dev("/dev/root", ROOT_DEV) < 0)
-		pr_err("Failed to create %s device !\n", "/dev/root");
-	mount_block_root("/dev/root", root_mountflags);
+	{
+		int err = create_dev("/dev/root", ROOT_DEV);
+
+		if (err < 0)
+			pr_emerg("Failed to create /dev/root: %d\n", err);
+		mount_block_root("/dev/root", root_mountflags);
+	}
 #endif
 }
 
_

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/