linux-kernel - Re: [PATCH] livepatch: match return value to function signature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55656EBC.4030200@suse.cz>
Date:	Wed, 27 May 2015 09:14:04 +0200
From:	Jiri Slaby <jslaby@...e.cz>
To:	Nicholas Mc Guire <der.herr@...r.at>
CC:	Nicholas Mc Guire <hofrat@...dl.org>,
	Josh Poimboeuf <jpoimboe@...hat.com>,
	Seth Jennings <sjenning@...hat.com>,
	Jiri Kosina <jkosina@...e.cz>,
	Vojtech Pavlik <vojtech@...e.cz>,
	live-patching@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] livepatch: match return value to function signature

On 05/27/2015, 08:56 AM, Nicholas Mc Guire wrote:
> On Mon, 11 May 2015, Jiri Slaby wrote:
> 
>> On 05/11/2015, 07:52 AM, Nicholas Mc Guire wrote:
>>> klp_initialized() should return bool but is actually returning 
>>> struct kobject * - convert it to a boolean explicitly.
>>>
>>> Signed-off-by: Nicholas Mc Guire <hofrat@...dl.org>
>>
>> Reviewed-by: Jiri Slaby <jslaby@...e.cz>
>>
> sorry for the noise - discussions about a similar "cleanup" in RCU
> resulted Joe Perches <joe@...ches.com> clarifying the matter - this
> explicit conversion makes static code checkers happy but is not
> needed for gcc (or C for that mater) - see 
>   http://lkml.org/lkml/2015/5/24/47
>   and ISO/IEC 9899:1999 (c99) 6.8.6.4 subclause 3)

Oh yes and I seem to be inconsistent with replies:
https://lkml.org/lkml/2015/5/26/90

> hofrat

You? Nuremberg, 2010, Stanse?

thanks,
-- 
js
suse labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/