linux-kernel - Re: dell_rbtn - kernel panic at boot...

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150527072823.GC30798@pali>
Date:	Wed, 27 May 2015 09:28:23 +0200
From:	Pali Rohár <pali.rohar@...il.com>
To:	Darren Hart <dvhart@...radead.org>
Cc:	Matthew Garrett <mjg59@...f.ucam.org>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Valdis Kletnieks <Valdis.Kletnieks@...edu>,
	lkml <linux-kernel@...r.kernel.org>,
	platform-driver-x86@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: dell_rbtn - kernel panic at boot...

On Tuesday 26 May 2015 21:16:58 Darren Hart wrote:
> On Mon, May 25, 2015 at 08:03:42AM +0200, Pali Rohár wrote:
> > On Monday 25 May 2015 07:01:21 Matthew Garrett wrote:
> > > On Sun, May 24, 2015 at 09:44:32PM -0700, Darren Hart wrote:
> > > > Greg, Matthew, I'm tempted to recommend this 434 line driver be
> > > > rolled into dell-laptop.c. Any strong opinions?
> > > 
> > > Mrm. It's slightly conceptually nasty in that one's an ACPI driver
> > > and one's calling a Dell custom interface, but I think merging them
> > > is probably the last bad answer.
> > 
> > I think merging does not fix our problem. dell laptop rfkill driver 
> > needs to be initialized after dell-rbtn acpi driver register itself.
> 
> If they were the same driver, you could control this ordering.
> 

Yes, I see, you are right. I can call acpi driver register function and
after that initializing dell laptop rfkill code.

> > 
> > And dell-laptop and dell-rbtn are two different devices (one dell smbios 
> > and one acpi) and it for me it sounds like bad idea too...
> 
> We all agree it's a bad idea - the point Mathew and I made was it may be the
> "least bad" idea (all the others may be worse).
> 
> I'm looking into this, but I don't have an easy answer for you. This one is
> going to take some research on your part to get to the right answer.
> 

I still think that changing module_init() could work... Do you know who
can help us with those _ini*() macros (and ideally answer how to do that)?

-- 
Pali Rohár
pali.rohar@...il.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/