linux-kernel - Re: [Drbd-dev] [PATCH] block:drbd:drbd_receiver - Change 1/0 to true/false for bool type variable rv in function overlapping_resync

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150527093136.GJ18767@soda.linbit>
Date:	Wed, 27 May 2015 11:31:36 +0200
From:	Lars Ellenberg <lars.ellenberg@...bit.com>
To:	Shailendra Verma <shailendra.capricorn@...il.com>
Cc:	drbd-dev@...ts.linbit.com, linux-kernel@...r.kernel.org
Subject: Re: [Drbd-dev] [PATCH] block:drbd:drbd_receiver - Change 1/0 to
 true/false for bool type variable rv in function overlapping_resync_write().

On Tue, May 26, 2015 at 01:45:09AM +0530, Shailendra Verma wrote:
> In function overlapping_resync_write() variable rv is bool type.
> Hence assigning the values as true/false instead of 1/0.

I like 0 and 1 better.  So unless the powers that be rule this to be the
recommended or mandatory coding style, I consider this just noise.

    Lars

> -	bool rv = 0;
> +	bool rv = false;

> -			rv = 1;
> +			rv = true;

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/