[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20150527102334.GD11677@x1>
Date: Wed, 27 May 2015 11:23:34 +0100
From: Lee Jones <lee.jones@...aro.org>
To: Krzysztof Kozlowski <k.kozlowski.k@...il.com>
Cc: Chanwoo Choi <cw00.choi@...sung.com>,
MyungJoo Ham <myungjoo.ham@...sung.com>,
Dmitry Torokhov <dmitry.torokhov@...il.com>,
Samuel Ortiz <sameo@...ux.intel.com>,
Sebastian Reichel <sre@...nel.org>,
Dmitry Eremin-Solenikov <dbaryshkov@...il.com>,
David Woodhouse <dwmw2@...radead.org>,
Liam Girdwood <lgirdwood@...il.com>,
Mark Brown <broonie@...nel.org>, linux-kernel@...r.kernel.org,
linux-input@...r.kernel.org, linux-pm@...r.kernel.org
Subject: Re: [PATCH v2 2/9] mfd: max77693: Store I2C device type as enum and
add default unknown
On Sun, 24 May 2015, Krzysztof Kozlowski wrote:
> Store the device type (obtained from i2c_device_id) as an enum and add a
> default type of unknown to distinguish from case when this is not set
> at all.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski.k@...il.com>
> ---
> include/linux/mfd/max77693-private.h | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
Applied, thanks.
> diff --git a/include/linux/mfd/max77693-private.h b/include/linux/mfd/max77693-private.h
> index ad67b8235a8d..e3c0afff38d3 100644
> --- a/include/linux/mfd/max77693-private.h
> +++ b/include/linux/mfd/max77693-private.h
> @@ -529,13 +529,18 @@ enum max77693_irq_muic {
> MAX77693_MUIC_IRQ_NR,
> };
>
> +enum max77693_types {
> + TYPE_MAX77693_UNKNOWN,
> + TYPE_MAX77693,
> +};
> +
> struct max77693_dev {
> struct device *dev;
> struct i2c_client *i2c; /* 0xCC , PMIC, Charger, Flash LED */
> struct i2c_client *muic; /* 0x4A , MUIC */
> struct i2c_client *haptic; /* 0x90 , Haptic */
>
> - int type;
> + enum max77693_types type;
>
> struct regmap *regmap;
> struct regmap *regmap_muic;
> @@ -549,8 +554,4 @@ struct max77693_dev {
> int irq;
> };
>
> -enum max77693_types {
> - TYPE_MAX77693,
> -};
> -
> #endif /* __LINUX_MFD_MAX77693_PRIV_H */
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists