linux-kernel - Re: [PATCH 4/4] perf: Add power8 PMU events in JSON format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150527135928.GB29557@danjae.kornet>
Date:	Wed, 27 May 2015 22:59:28 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	Sukadev Bhattiprolu <sukadev@...ux.vnet.ibm.com>
Cc:	mingo@...hat.com, ak@...ux.intel.com,
	Michael Ellerman <mpe@...erman.id.au>,
	Jiri Olsa <jolsa@...hat.com>,
	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Paul Mackerras <paulus@...ba.org>,
	linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/4] perf: Add power8 PMU events in JSON format

On Tue, May 19, 2015 at 05:02:10PM -0700, Sukadev Bhattiprolu wrote:
> The power8.json and 004d0100.json files describe the PMU events in the
> Power8 processor.
> 
> The jevents program from the prior patches will use these JSON files
> to create tables which will then be used in perf to build aliases for
> PMU events. This in turn would allow users to specify these PMU events
> by name:
> 
> 	$ perf stat -e pm_1plus_ppc_cmpl sleep 1
> 
> Signed-off-by: Sukadev Bhattiprolu <sukadev@...ux.vnet.ibm.com>
> ---

[SNIP]
> +  {
> +    "EventCode": "0x2505e",
> +    "EventName": "PM_BACK_BR_CMPL",
> +    "BriefDescription": "Branch instruction completed with a target address less than current instruction address,",
> +    "PublicDescription": "Branch instruction completed with a target address less than current instruction address.,"

Can't we remove PublicDescription field if it's identical to
BriefDescription?  It seems just wasting spaces..

Thanks,
Namhyung


> +  },
> +  {
> +    "EventCode": "0x4082",
> +    "EventName": "PM_BANK_CONFLICT",
> +    "BriefDescription": "Read blocked due to interleave conflict. The ifar logic will detect an interleave conflict and kill the data that was read that cycle.,",
> +    "PublicDescription": "Read blocked due to interleave conflict. The ifar logic will detect an interleave conflict and kill the data that was read that cycle.,"
> +  },
> +  {
> +    "EventCode": "0x10068",
> +    "EventName": "PM_BRU_FIN",
> +    "BriefDescription": "Branch Instruction Finished,",
> +    "PublicDescription": "Branch Instruction Finished .,"
> +  },
> +  {
> +    "EventCode": "0x20036",
> +    "EventName": "PM_BR_2PATH",
> +    "BriefDescription": "two path branch,",
> +    "PublicDescription": "two path branch.,"
> +  },
> +  {
> +    "EventCode": "0x5086",
> +    "EventName": "PM_BR_BC_8",
> +    "BriefDescription": "Pairable BC+8 branch that has not been converted to a Resolve Finished in the BRU pipeline,",
> +    "PublicDescription": "Pairable BC+8 branch that has not been converted to a Resolve Finished in the BRU pipeline,"
> +  },
> +  {
> +    "EventCode": "0x5084",
> +    "EventName": "PM_BR_BC_8_CONV",
> +    "BriefDescription": "Pairable BC+8 branch that was converted to a Resolve Finished in the BRU pipeline.,",
> +    "PublicDescription": "Pairable BC+8 branch that was converted to a Resolve Finished in the BRU pipeline.,"
> +  },
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/