linux-kernel - Re: [PATCH v2] staging: lustre: fix non-static symbol warnings reported by sparse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 27 May 2015 07:53:30 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Marcus Folkesson <marcus.folkesson@...il.com>
Cc:	Oleg Drokin <oleg.drokin@...el.com>,
	Andreas Dilger <andreas.dilger@...el.com>,
	Greg Donald <gdonald@...il.com>,
	Julia Lawall <Julia.Lawall@...6.fr>,
	Daniel Baluta <daniel.baluta@...el.com>,
	Lai Siyao <lai.siyao@...el.com>,
	Andriy Skulysh <Andriy_Skulysh@...atex.com>,
	Joe Perches <joe@...ches.com>, HPDD-discuss@...ts.01.org,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] staging: lustre: fix non-static symbol warnings
 reported by sparse

On Wed, May 27, 2015 at 04:47:56PM +0200, Marcus Folkesson wrote:
> Warnings reported by sparse:
> 
> drivers/staging/lustre/lustre/ptlrpc/pinger.c:94:5:
> warning: symbol 'ptlrpc_ping' was not declared. Should it be static?
> 
> drivers/staging/lustre/lustre/ptlrpc/pinger.c:113:6:
> warning: symbol 'ptlrpc_update_next_ping' was not declared. Should it be static
> 
> drivers/staging/lustre/lustre/ptlrpc/pinger.c:144:6:
> warning: symbol 'pinger_check_timeout' was not declared. Should it be static?
> 
> drivers/staging/lustre/lustre/ptlrpc/pinger.c:425:21:
> warning: symbol 'ptlrpc_new_timeout' was not declared. Should it be static?
> 
> drivers/staging/lustre/lustre/ptlrpc/pinger.c:551:1:
> warning: symbol 'pet_list' was not declared. Should it be static?
> 
> Signed-off-by: Marcus Folkesson <marcus.folkesson@...il.com>
> ---
>  drivers/staging/lustre/lustre/ptlrpc/pinger.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)

What changed in v2 needs to go here, below the --- line, not in a
separate email that will get lost, especially as it has a very odd
subject line :(

Please fix up and resend.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/