linux-kernel - Re: [PATCH v2] rtc: pcf8563 fix: return -EINVAL if we read an invalid time.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150527185352.GJ2185@piout.net>
Date:	Wed, 27 May 2015 20:53:52 +0200
From:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>
To:	Jan Kardell <jan.kardell@...liq.com>
Cc:	Alessandro Zummo <a.zummo@...ertech.it>,
	rtc-linux@...glegroups.com, linux-kernel@...r.kernel.org,
	Vincent Donnefort <vdonnefort@...il.com>,
	Dan Carpenter <dan.carpenter@...cle.com>, oen@...liq.com
Subject: Re: [PATCH v2] rtc: pcf8563 fix: return -EINVAL if we read an
 invalid time.

Hi,

On 27/05/2015 at 14:48:16 +0200, Jan Kardell wrote :
> @@ -204,6 +204,7 @@ static int pcf8563_get_datetime(struct i2c_client *client, struct rtc_time *tm)
>  		pcf8563->voltage_low = 1;
>  		dev_info(&client->dev,

Aren't dev_err or dev_warn more appropriate? You used dev_err in your
first patch, what made you change your mind?

>  			"low voltage detected, date/time is not reliable.\n");
> +		return -EINVAL;
>  	}
>  
>  	dev_dbg(&client->dev,

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/