linux-kernel - Re: [PATCH] staging: gdm72xx: remove unneeded test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 27 May 2015 17:46:35 -0300
From:	Fabio Estevam <festevam@...il.com>
To:	Laurent Navet <laurent.navet@...il.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: gdm72xx: remove unneeded test

On Wed, May 27, 2015 at 5:25 PM, Laurent Navet <laurent.navet@...il.com> wrote:
> The same code is executed regardless ret value, so this test can be
> removed.
>
> Signed-off-by: Laurent Navet <laurent.navet@...il.com>
> ---
>  drivers/staging/gdm72xx/usb_boot.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/staging/gdm72xx/usb_boot.c b/drivers/staging/gdm72xx/usb_boot.c
> index 3ccc447..7f80553 100644
> --- a/drivers/staging/gdm72xx/usb_boot.c
> +++ b/drivers/staging/gdm72xx/usb_boot.c
> @@ -255,8 +255,6 @@ static int em_wait_ack(struct usb_device *usbdev, int send_zlp)
>
>         /*Wait for ACK*/
>         ret = gdm_wibro_recv(usbdev, &ack, sizeof(ack));
> -       if (ret < 0)
> -               goto out;
>  out:
>         return ret;
>  }

What about removing the 'out' label like this?

--- a/drivers/staging/gdm72xx/usb_boot.c
+++ b/drivers/staging/gdm72xx/usb_boot.c
@@ -250,15 +250,11 @@ static int em_wait_ack(struct usb_device *usbdev, int send
                /*Send ZLP*/
                ret = gdm_wibro_send(usbdev, NULL, 0);
                if (ret < 0)
-                       goto out;
+                       return ret;
        }

        /*Wait for ACK*/
-       ret = gdm_wibro_recv(usbdev, &ack, sizeof(ack));
-       if (ret < 0)
-               goto out;
-out:
-       return ret;
+       return gdm_wibro_recv(usbdev, &ack, sizeof(ack));
 }
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/