linux-kernel - Re: [PATCH] clockevents: timer-stm32: Fix build warning spotted by kbuild test robot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALszF6BeHMnc_snZmMBLgvw6i_7khHuE_g5On7sRrm3dbQawnA@mail.gmail.com>
Date:	Thu, 28 May 2015 07:03:36 +0200
From:	Maxime Coquelin <mcoquelin.stm32@...il.com>
To:	Luc Van Oostenryck <luc.vanoostenryck@...il.com>
Cc:	Daniel Lezcano <daniel.lezcano@...aro.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	fengguang.wu@...el.com
Subject: Re: [PATCH] clockevents: timer-stm32: Fix build warning spotted by
 kbuild test robot

2015-05-28 0:52 GMT+02:00 Luc Van Oostenryck <luc.vanoostenryck@...il.com>:
> On Wed, May 27, 2015 at 06:41:23PM +0200, Maxime Coquelin wrote:
>>
>>       /* Detect whether the timer is 16 or 32 bits */
>> -     writel_relaxed(~0UL, data->base + TIM_ARR);
>> +     writel_relaxed((u32)~0UL, data->base + TIM_ARR);
>>       max_delta = readl_relaxed(data->base + TIM_ARR);
>>       if (max_delta == ~0UL) {
>>               prescaler = 1;
>
>
> Since the warning come from using a unsigned long constant while
> writel() expect an unsigned int, why not simply use ~0U ?

You are right, this is indeed the right fix.
I'm sending the v2 now, using ~0U.

Thanks,
Maxime
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/