[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAPDyKFrOUOuctSMpx+RFixB_ub=d66YqXEsa7D78gyFeiGiNkQ@mail.gmail.com>
Date: Thu, 28 May 2015 09:20:18 +0200
From: Ulf Hansson <ulf.hansson@...aro.org>
To: Peter Ujfalusi <peter.ujfalusi@...com>
Cc: Vinod Koul <vinod.koul@...el.com>,
Tony Lindgren <tony@...mide.com>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
Dan Williams <dan.j.williams@...el.com>,
dmaengine@...r.kernel.org, linux-serial@...r.kernel.org,
linux-omap <linux-omap@...r.kernel.org>,
linux-mmc <linux-mmc@...r.kernel.org>,
linux-crypto@...r.kernel.org,
"linux-spi@...r.kernel.org" <linux-spi@...r.kernel.org>,
linux-media@...r.kernel.org, alsa-devel@...a-project.org
Subject: Re: [PATCH 04/13] mmc: omap_hsmmc: No need to check DMA channel
validity at module remove
On 26 May 2015 at 15:25, Peter Ujfalusi <peter.ujfalusi@...com> wrote:
> The driver will not probe without valid DMA channels so no need to check
> if they are valid when the module is removed.
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@...com>
> CC: Ulf Hansson <ulf.hansson@...aro.org>
Acked-by: Ulf Hansson <ulf.hansson@...aro.org>
Kind regards
Uffe
> ---
> drivers/mmc/host/omap_hsmmc.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
> index 2cd828f42151..57bb85930f81 100644
> --- a/drivers/mmc/host/omap_hsmmc.c
> +++ b/drivers/mmc/host/omap_hsmmc.c
> @@ -2190,10 +2190,8 @@ static int omap_hsmmc_remove(struct platform_device *pdev)
> if (host->use_reg)
> omap_hsmmc_reg_put(host);
>
> - if (host->tx_chan)
> - dma_release_channel(host->tx_chan);
> - if (host->rx_chan)
> - dma_release_channel(host->rx_chan);
> + dma_release_channel(host->tx_chan);
> + dma_release_channel(host->rx_chan);
>
> pm_runtime_put_sync(host->dev);
> pm_runtime_disable(host->dev);
> --
> 2.3.5
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists