linux-kernel - Re: [PATCH] Staging: vt6655: Remove unnecessary equality checks for a bool variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1432800940.2846.207.camel@perches.com>
Date:	Thu, 28 May 2015 01:15:40 -0700
From:	Joe Perches <joe@...ches.com>
To:	"Harisangam, Sharvari (S.)" <sharisan@...teon.com>
Cc:	"forest@...ttletooquiet.net" <forest@...ttletooquiet.net>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"tvboxspy@...il.com" <tvboxspy@...il.com>,
	"gclement@...bob.org" <gclement@...bob.org>,
	"haticeerturk27@...il.com" <haticeerturk27@...il.com>,
	"mahfouz.saif.elyazal@...il.com" <mahfouz.saif.elyazal@...il.com>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Staging: vt6655: Remove unnecessary equality checks for
 a bool variable

On Thu, 2015-05-28 at 06:10 +0000, Harisangam, Sharvari (S.) wrote:
> Modified the if-else statements to remove unnecessary comparisons.
> This change was detected with the help of coccinelle tool

Your commit subject implies you are doing this for the
directory, not a single file.

If you are going to do this, please do it for all files
in the directory.  

$ git grep  -w -E "if\s*\(.*(true|false)" drivers/staging/vt6655/
drivers/staging/vt6655/card.c:  if (pDevice->bRadioOff == true)
drivers/staging/vt6655/card.c:  if (pDevice->bRadioControlOff == true) {
drivers/staging/vt6655/card.c:          if (pDevice->bHWRadioOff == true)
drivers/staging/vt6655/card.c:          if (pDevice->bRadioControlOff == true)
drivers/staging/vt6655/card.c:  if (pDevice->bRadioOff == false) {
drivers/staging/vt6655/rxtx.c:                  if (bRTS == true) {/* RTS_need */
drivers/staging/vt6655/rxtx.c:                  if (bRTS == true) {/* RTS_need */
drivers/staging/vt6655/rxtx.c:                  if (bRTS == true) {
drivers/staging/vt6655/rxtx.c:                  if (bRTS == true) { /* RTS_need */


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/