linux-kernel - Re: [ANNOUNCE] 4.0.4-rt1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 28 May 2015 10:41:28 +0200
From:	Joakim Hernberg <jhernberg@...hemy.lu>
To:	Clark Williams <williams@...hat.com>
Cc:	Steven Rostedt <rostedt@...dmis.org>,
	Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
	linux-rt-users <linux-rt-users@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	John Kacur <jkacur@...hat.com>
Subject: Re: [ANNOUNCE] 4.0.4-rt1

On Tue, 26 May 2015 10:43:43 -0500
Clark Williams <williams@...hat.com> wrote:

> On Tue, 26 May 2015 11:19:24 -0400
> Steven Rostedt <rostedt@...dmis.org> wrote:
> 
> > On Tue, 26 May 2015 08:48:02 -0500
> > Clark Williams <williams@...hat.com> wrote:
> > 
> > 
> > > Change the WARN_ON to WARN_ON_NORT
> > 
> > Do we have a WARN_ON_NORT? I see a WARN_ON_NONRT, but not a
> > WARN_ON_NORT. Does this compile?
> > 
> > -- Steve
> 
> Sigh. Of course not. Reupdated patch (and yes this one compiles):
> 
> From: Clark Williams <williams@...hat.com>
> Date: Thu, 21 May 2015 12:51:53 -0500
> Subject: [PATCH] [rt] i915: bogus warning from i915 when running on
> PREEMPT_RT
> 
> The i915 driver has a 'WARN_ON(!in_interrupt())' in the display
> handler, which whines constanly on the RT kernel (since the interrupt
> is actually handled in a threaded handler and not actual interrupt
> context).
> 
> Change the WARN_ON to WARN_ON_NORT
> 
> Signed-off-by: Clark Williams <williams@...hat.com>
> ---
>  drivers/gpu/drm/i915/intel_display.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_display.c
> b/drivers/gpu/drm/i915/intel_display.c index
> f75173c20f47..30b1d16caa0d 100644 ---
> a/drivers/gpu/drm/i915/intel_display.c +++
> b/drivers/gpu/drm/i915/intel_display.c @@ -9745,7 +9745,7 @@ void
> intel_check_page_flip(struct drm_device *dev, int pipe) struct
> drm_crtc *crtc = dev_priv->pipe_to_crtc_mapping[pipe]; struct
> intel_crtc *intel_crtc = to_intel_crtc(crtc); 
> -	WARN_ON(!in_interrupt());
> +	WARN_ON_NONRT(!in_interrupt());
>  
>  	if (crtc == NULL)
>  		return;

You can add my Tested-by: Joakim Hernberg <jhernberg@...hemy.lu>.
Seems to fix the problem on my systems too.

-- 

   Joakim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/