[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20150528085124.GA26120@lst.de>
Date: Thu, 28 May 2015 10:51:24 +0200
From: Christoph Hellwig <hch@....de>
To: Dan Williams <dan.j.williams@...el.com>
Cc: axboe@...nel.dk, Boaz Harrosh <boaz@...xistor.com>, neilb@...e.de,
Dave Chinner <david@...morbit.com>,
Lv Zheng <lv.zheng@...el.com>,
"H. Peter Anvin" <hpa@...or.com>, hch@....de, sfr@...b.auug.org.au,
linux-nvdimm@...ts.01.org,
"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
Robert Moore <robert.moore@...el.com>, mingo@...nel.org,
linux-acpi@...r.kernel.org, jmoyer@...hat.com,
Nicholas Moulin <nicholas.w.moulin@...ux.intel.com>,
Matthew Wilcox <willy@...ux.intel.com>,
Ross Zwisler <ross.zwisler@...ux.intel.com>,
Vishal Verma <vishal.l.verma@...ux.intel.com>,
Jens Axboe <axboe@...com>, Borislav Petkov <bp@...en8.de>,
Thomas Gleixner <tglx@...utronix.de>,
gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
Andy Lutomirski <luto@...capital.net>,
akpm@...ux-foundation.org,
Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [GIT PULL v4 00/21] libnd: non-volatile memory device support
On Wed, May 27, 2015 at 06:24:42PM -0400, Dan Williams wrote:
> Jens, please pull from...
>
> git://git.kernel.org/pub/scm/linux/kernel/git/djbw/nvdimm tags/libnd-for-jens
I don't really think it's quite ready. I don't have time to sort through
the giant steaming pile for now, but there are a few things here:
- stong NAK for the linker wrapping abuse in the test module
- you must run the ioctls past the linux-api list at least
- please make sure the legacy e820 changes are properly tested. I could
take of it, but not until Wednesday next week as I'm travelling right
now.
Also a little nitpick on naming: why is this still nd instead of the
widely used nvdimm? Also as very little of it is related to block drivers
and a lot is management it should be under drivers/ not drivers/block/
I think.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists