linux-kernel - Re: [PATCH] ARM: dts: odroidxu3: Enable USB3 regulators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <5566DDA6.1080508@samsung.com>
Date:	Thu, 28 May 2015 18:19:34 +0900
From:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
To:	Anand Moon <linux.amoon@...il.com>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Russell King <linux@....linux.org.uk>,
	Kukjin Kim <kgene@...nel.org>
Cc:	devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: dts: odroidxu3: Enable USB3 regulators

On 28.05.2015 17:58, Anand Moon wrote:
> Enable regulator for usbdrd3_0 and usbdrd3_1
>>>From the schematic pin diagram USB3_0 and USB3_1
> is regulated by LDO9 and LD011.

Please reformat statement above to proper sentence(s) without ">" before
"From".

> 
> Fix the boot message of failed.
> [    3.503539] exynos-dwc3 usb@...00000: Looking up vdd33-supply from device tree
> [    3.503556] exynos-dwc3 usb@...00000: Looking up vdd33-supply property in node /usb@...00000 failed
> [    3.503568] usb@...00000 supply vdd33 not found, using dummy regulator
> [    3.509154] exynos-dwc3 usb@...00000: Looking up vdd10-supply from device tree
> [    3.509170] exynos-dwc3 usb@...00000: Looking up vdd10-supply property in node /usb@...00000 failed
> [    3.509181] usb@...00000 supply vdd10 not found, using dummy regulator
> [    3.917548] exynos-dwc3 usb@...00000: Looking up vdd33-supply from device tree
> [    3.917565] exynos-dwc3 usb@...00000: Looking up vdd33-supply property in node /usb@...00000 failed
> [    3.917578] usb@...00000 supply vdd33 not found, using dummy regulator
> [    3.922731] exynos-dwc3 usb@...00000: Looking up vdd10-supply from device tree
> [    3.922747] exynos-dwc3 usb@...00000: Looking up vdd10-supply property in node /usb@...00000 failed
> 
> ---
> This patch is based on Krzysztof github branch work-next/odroid-xu3-s2mps11-irq
> ---

I mentioned this already on previous postings. Let's make an exercise.
Please:
1. Save your email as mbox format (from mailer).
2. Go to a GIT repo with kernel and checkout base branch.
3. git am 0001-the-name-of-file.mbox
4. git show

Do you see the signed-off-by in commit?

The patch itself looks good, thanks for fixing this. Just please fix the
issues with commit message.

By the way:
1. The always-on from LDO9 could be probably removed if the ehci-exynos
driver had regulator consumer implemented.
2. The Documentation/devicetree/bindings/usb/exynos-usb.txt (or dwc.txt)
should proably mention the vdd-supply property.

Best regards,
Krzysztof


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/