linux-kernel - Re: [PATCH 1/3] X.509: Fix certificate gathering again

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1432807532.3499.31.camel@infradead.org>
Date:	Thu, 28 May 2015 11:05:32 +0100
From:	David Woodhouse <dwmw2@...radead.org>
To:	David Howells <dhowells@...hat.com>
Cc:	Michal Marek <mmarek@...e.cz>, torvalds@...ux-foundation.org,
	aricart@...nix.com, linux-kernel@...r.kernel.org,
	sedat.dilek@...il.com, keyrings@...ux-nfs.org,
	rusty@...tcorp.com.au, linux-security-module@...r.kernel.org,
	james.l.morris@...cle.com
Subject: Re: [PATCH 1/3] X.509: Fix certificate gathering again

On Thu, 2015-05-28 at 10:58 +0100, David Howells wrote:
> David Woodhouse <dwmw2@...radead.org> wrote:
> 
> > > The only issue is that the makefile expressions are a bit hairy. For
> > > starters, we already have definitions for $(quote) and $(space) in
> > > kbuild. I'll have a closer look at the config_filename macro and try to
> > > simplify it somehow. But it's just cosmetics, the patch can be merged as
> > > is for now.
> > 
> > I've actually changed my mind about the 'awk | base64 -d' bit. The error
> > handling is too poor. I'd like to do that in C with a variant of the
> > existing extract_cert tool, and make sure we have proper X.509
> > certificates and error handling/reporting.
> 
> You could also do it in perl pretty easily.

It's a fairly trivial change to scripts/extract-cert.c though, which
gives you validation of the cert ASN.1 instead of just base64-decoding
and importing arbitrary crap as long as it's found between
 -----BEGIN CERTIFICATE-----
and
 -----END CERTIFICATE-----

Yeah, we could do the X.509 parsing/validation in perl too. But let's
not.

-- 
David Woodhouse                            Open Source Technology Centre
David.Woodhouse@...el.com                              Intel Corporation

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/