linux-kernel - Re: [PATCH] block: fix returnvar.cocci warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <55667183.80203@kernel.dk>
Date:	Wed, 27 May 2015 19:38:11 -0600
From:	Jens Axboe <axboe@...nel.dk>
To:	Rik van Riel <riel@...hat.com>,
	Julia Lawall <julia.lawall@...6.fr>,
	Christoph Hellwig <hch@....de>
CC:	Jeff Moyer <jmoyer@...hat.com>,
	Alexander Viro <viro@...iv.linux.org.uk>,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] block: fix returnvar.cocci warnings

On 05/27/2015 07:36 PM, Rik van Riel wrote:
> On 05/26/2015 03:59 PM, Julia Lawall wrote:
>> Remove unneeded variable used to store return value.
>>
>> Generated by: scripts/coccinelle/misc/returnvar.cocci
>>
>> Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
>> Signed-off-by: Julia Lawall <julia.lawall@...6.fr>
>> ---
>>
>> One could check whether the ret variable was intended to be used for
>> anything.
>
> Which tree is this against?
>
> Linus's latest tree still has this in _submit_bh
> (unless git didn't pull the latest updates right):
>
>          if (buffer_meta(bh))
>                  rw |= REQ_META;
>          if (buffer_prio(bh))
>                  rw |= REQ_PRIO;
>
>          bio_get(bio);
>          submit_bio(rw, bio);
>
>          if (bio_flagged(bio, BIO_EOPNOTSUPP))
>                  ret = -EOPNOTSUPP;
>
>          bio_put(bio);
>          return ret;

for-4.2/core has dropped the EOPNOTSUPP parts, that's where Julia found 
the issue of the now unused 'ret'.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/