[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20150528130324.GD9540@dhcp22.suse.cz>
Date: Thu, 28 May 2015 15:03:24 +0200
From: Michal Hocko <mhocko@...e.cz>
To: Wang Long <long.wanglong@...wei.com>
Cc: akpm@...ux-foundation.org, rientjes@...gle.com,
vdavydov@...allels.com, hannes@...xchg.org, oleg@...hat.com,
kirill.shutemov@...ux.intel.com, linux-mm@...ck.org,
linux-kernel@...r.kernel.org, wanglong@...qinren.net,
peifeiyue@...wei.com
Subject: Re: [PATCH] OOM: print points as unsigned int
On Thu 28-05-15 09:46:44, Wang Long wrote:
> In oom_kill_process(), the variable 'points' is unsigned int.
> Print it as such.
>
> Signed-off-by: Wang Long <long.wanglong@...wei.com>
I do not think this matter much in the real life but there is no reason
to use a wrong format type.
Acked-by: Michal Hocko <mhocko@...e.cz>
Thanks!
> ---
> mm/oom_kill.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/oom_kill.c b/mm/oom_kill.c
> index 2b665da..056002c 100644
> --- a/mm/oom_kill.c
> +++ b/mm/oom_kill.c
> @@ -528,7 +528,7 @@ void oom_kill_process(struct task_struct *p, gfp_t gfp_mask, int order,
> dump_header(p, gfp_mask, order, memcg, nodemask);
>
> task_lock(p);
> - pr_err("%s: Kill process %d (%s) score %d or sacrifice child\n",
> + pr_err("%s: Kill process %d (%s) score %u or sacrifice child\n",
> message, task_pid_nr(p), p->comm, points);
> task_unlock(p);
>
> --
> 1.8.3.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Michal Hocko
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists