linux-kernel - Re: [PATCH 6/9] input: goodix: write configuration data to device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150528132133.GI23176@leverpostej>
Date:	Thu, 28 May 2015 14:21:33 +0100
From:	Mark Rutland <mark.rutland@....com>
To:	Irina Tirdea <irina.tirdea@...el.com>
Cc:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Bastien Nocera <hadess@...ess.net>,
	"linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Octavian Purdila <octavian.purdila@...el.com>
Subject: Re: [PATCH 6/9] input: goodix: write configuration data to device

On Thu, May 28, 2015 at 01:47:42PM +0100, Irina Tirdea wrote:
> Goodix devices can be configured by writing this information
> to the device at init. The configuration data can
> be provided through the ACPI/device tree property
> "device-config". If "device-config" is not set, the default
> device configuration will be used.
> 
> Signed-off-by: Octavian Purdila <octavian.purdila@...el.com>
> Signed-off-by: Irina Tirdea <irina.tirdea@...el.com>
> ---
>  .../bindings/input/touchscreen/goodix.txt          |   5 +
>  drivers/input/touchscreen/goodix.c                 | 143 +++++++++++++++++++++
>  2 files changed, 148 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/goodix.txt b/Documentation/devicetree/bindings/input/touchscreen/goodix.txt
> index 7137881..9e4ff69 100644
> --- a/Documentation/devicetree/bindings/input/touchscreen/goodix.txt
> +++ b/Documentation/devicetree/bindings/input/touchscreen/goodix.txt
> @@ -15,6 +15,11 @@ Required properties:
>   - irq-gpio		: GPIO pin used for IRQ
>   - reset-gpio		: GPIO pin used for reset
>  
> +Optional properties:
> +
> + - device-config	: device configuration information (specified as byte
> +			  array). Maximum size is 240 bytes.

Generally we frown on passing opaque data.

What exactly is encoded in device-config? The description is very vague.

Does this correspond to anything in a data sheet or manual?

Mark.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/