linux-kernel - Re: [PATCH 1/2] regulator: core: add support to get VSEL register from hw driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150528135245.GU21577@sirena.org.uk>
Date:	Thu, 28 May 2015 14:52:45 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Laxman Dewangan <ldewangan@...dia.com>
Cc:	lgirdwood@...il.com, linux-kernel@...r.kernel.org,
	cfreeman@...dia.com, abrestic@...omium.org
Subject: Re: [PATCH 1/2] regulator: core: add support to get VSEL register
 from hw driver

On Wed, May 27, 2015 at 08:10:20PM +0530, Laxman Dewangan wrote:

> Add callback on the regulator ops to get the voltage selection
> register address and mask from device regulator driver. Use this
> new callback in regulator_get_hardware_vsel_register().

It's not entirely clear to me that this is a good idea - the expected
use case for getting the vsel register is to hand it off to something
like a microcontroller for it to use but if the vsel register might
change at runtime then we also need infrastructure to synchronize those
changes with whatever is using the register.  How does your system keep
them in sync?

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)