linux-kernel - Re: [PATCH] ALSA: aoa: convert bus code to use dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hsiag7q0p.wl-tiwai@suse.de>
Date:	Thu, 28 May 2015 16:09:10 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Quentin Lambert <lambert.quentin@...il.com>
Cc:	Johannes Berg <johannes@...solutions.net>,
	Jaroslav Kysela <perex@...ex.cz>,
	linuxppc-dev@...ts.ozlabs.org, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] ALSA: aoa: convert bus code to use dev_groups

At Thu, 28 May 2015 15:59:50 +0200,
Quentin Lambert wrote:
> 
> 
> 
> On 28/05/2015 15:52, Takashi Iwai wrote:
> > At Thu, 28 May 2015 14:48:27 +0200,
> > Quentin Lambert wrote:
> >> You should use dev_groups instead of the dev_attrs field of struct
> >> bus_type. This converts the MDIO bus code to use the correct field.
> >>
> >> These modifications were made using Coccinelle.
> >>
> >> Signed-off-by: Quentin Lambert <lambert.quentin@...il.com>
> > What's wrong with dev_attrs?
> > (Not offending, I'm just curious where the preference for dev_groups
> >   is referred...)
> 
> This patch is based on commit 4192c74940e23da727eb02b7b4ee779dde2f670,
> its message indicates that dev_attrs is going away.

OK, makes sense.  Then please keep such information in the changelog.
BTW, the code in question isn't MDIO at all.

Also, it'd be better to move ATTRIBUTE_GROUPS(soundbus_dev) into
soundbus/sysfs.c, and make it this global instead of
soundbus_dev_attrs[].


Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/