linux-kernel - Re: [PATCH] core: Convert the function process

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <1432777672.2846.190.camel@perches.com>
Date:	Wed, 27 May 2015 18:47:52 -0700
From:	Joe Perches <joe@...ches.com>
To:	Nicholas Krause <xerofoify@...il.com>
Cc:	davem@...emloft.ne, brouer@...hat.com, edumazet@...gle.com,
	ast@...mgrid.com, sd@...asysnail.net,
	elfring@...rs.sourceforge.net, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] core: Convert the function process_ipcsec to the,
 return type bool

On Wed, 2015-05-27 at 21:14 -0400, Nicholas Krause wrote:
> This makes the function,process_ipsec have a return true
> of bool now due to only returning 1 or 0. In additon this
> changes this function's return statements to return true
> and false rather then 1 and 0 respectfully.

The patch subject title and the grammar in the commit message
could be improved, but other than that, it seems OK to me.

I would have written something like:

Subject: [PATCH] pktgen: Convert return type of process_ipsec to bool

It's used as a bool function, make it so.
Convert the return 1/0 to return true/false too.

Signed-off-by: etc...


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/