linux-kernel - Re: [Spice-devel] [PATCH 01/11] Do not cause spice-server to clean our objects

Open Source and information security mailing list archives

Message-ID: <CAPM=9tz0+OEhU=JV4fNgy3ruGxemWzHkRovEmnPzdbGGX+uivw@mail.gmail.com>
Date:	Thu, 28 May 2015 13:08:03 +1000
From:	Dave Airlie <airlied@...il.com>
To:	Frediano Ziglio <fziglio@...hat.com>
Cc:	spice-devel <spice-devel@...ts.freedesktop.org>,
	Dave Airlie <airlied@...ux.ie>,
	dri-devel <dri-devel@...ts.freedesktop.org>,
	Dave Airlie <airlied@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [Spice-devel] [PATCH 01/11] Do not cause spice-server to clean
 our objects

On 27 May 2015 at 20:03, Frediano Ziglio <fziglio@...hat.com> wrote:
> If objects are moved back from system memory to VRAM (and spice id
> created again) memory is already initialized so we need to set flag
> to not clear memory.
> If you don't do it after a while using desktop many images turns to
> black or transparents.

Good point,

Reviewed-by: Dave Airlie <airlied@...hat.com>
>
> Signed-off-by: Frediano Ziglio <fziglio@...hat.com>
> ---
>  qxl/qxl_cmd.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/qxl/qxl_cmd.c b/qxl/qxl_cmd.c
> index bd5404e..85ed5dc 100644
> --- a/qxl/qxl_cmd.c
> +++ b/qxl/qxl_cmd.c
> @@ -502,6 +502,7 @@ int qxl_hw_surface_alloc(struct qxl_device *qdev,
>
>         cmd = (struct qxl_surface_cmd *)qxl_release_map(qdev, release);
>         cmd->type = QXL_SURFACE_CMD_CREATE;
> +       cmd->flags = QXL_SURF_FLAG_KEEP_DATA;
>         cmd->u.surface_create.format = surf->surf.format;
>         cmd->u.surface_create.width = surf->surf.width;
>         cmd->u.surface_create.height = surf->surf.height;
> --
> 2.1.0
>
> _______________________________________________
> Spice-devel mailing list
> Spice-devel@...ts.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives