linux-kernel - Re: [PATCH] Revert "PCI/PM: Remove pci_pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0iCv=qwNOeLnOh+cRum=UmyUp48M-gc3LkU91U5hdPeBg@mail.gmail.com>
Date:	Thu, 28 May 2015 22:38:47 +0200
From:	"Rafael J. Wysocki" <rafael@...nel.org>
To:	"Rafael J. Wysocki" <rjw@...ysocki.net>
Cc:	Linux PCI <linux-pci@...r.kernel.org>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Linux PM list <linux-pm@...r.kernel.org>
Subject: Re: [PATCH] Revert "PCI/PM: Remove pci_pm_complete()"

On Thu, May 28, 2015 at 4:12 AM, Rafael J. Wysocki <rjw@...ysocki.net> wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
>
> Revert commit 84822b158fd3 "PCI/PM: Remove pci_pm_complete()" that
> removed the execution of the device driver's ->complete callback
> from the PCI bus type.
>
> That was a mistake, because those callbacks are not executed at all
> now even if present.
>
> Fixes: 84822b158fd3 "PCI/PM: Remove pci_pm_complete()"
> Cc: 3.13+ <stable@...r.kernel.org> # 3.13+
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>

Scratch this, sorry.

The code is correct as is, because the bus type doesn't provide
->complete at all in which case the core will run the driver's
callback directly.

We'll probably need ->complete for PCI at one point, but then I'll
resubmit this one with a different changelog.

Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/