linux-kernel - RE: Build errors in -next due to 'drivers:usb:fsl:Make fsl ehci drv an independent driver module'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SN1PR0301MB1583B121602C0F5C8AD4FCE4E0CA0@SN1PR0301MB1583.namprd03.prod.outlook.com>
Date:	Thu, 28 May 2015 03:55:24 +0000
From:	Ramneek Mehresh <ramneek.mehresh@...escale.com>
To:	Guenter Roeck <linux@...ck-us.net>
CC:	Alan Stern <stern@...land.harvard.edu>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-next@...r.kernel.org" <linux-next@...r.kernel.org>
Subject: RE: Build errors in -next due to 'drivers:usb:fsl:Make fsl ehci drv
 an independent driver module'



> -----Original Message-----
> From: Guenter Roeck [mailto:linux@...ck-us.net]
> Sent: Thursday, May 28, 2015 1:29 AM
> To: Mehresh Ramneek-B31383
> Cc: Alan Stern; Greg Kroah-Hartman; linux-kernel@...r.kernel.org; linux-
> next@...r.kernel.org
> Subject: Build errors in -next due to 'drivers:usb:fsl:Make fsl ehci drv an
> independent driver module'
> 
> Hi,
> 
> your patch 'drivers:usb:fsl:Make fsl ehci drv an independent driver module'
> converts the driver into a separate module. Unfortunately, it uses non-
> exported functions from the ehci core code. This results in compile errors for
> several powerpc configurations.
> 
> drivers/usb/host/ehci-fsl.c: In function 'ehci_fsl_drv_suspend':
> drivers/usb/host/ehci-fsl.c:531:2: error: implicit declaration of function
> 'ehci_adjust_port_wakeup_flags'
> drivers/usb/host/ehci-fsl.c: In function 'ehci_fsl_drv_resume':
> drivers/usb/host/ehci-fsl.c:561:2: error: implicit declaration of function
> 'ehci_reset'
>
Understood...apologies for the inconvenience caused. This problem comes when both 
ehci_hcd and ehci_fsl are built as modules. Till now, only ehci-hcd was build as 
module, and other drivers were built into it. I tested ehci_fsl as a module with ehci_hcd as build-in.

Now, there are two solutions for this.
1. export each function in ehci_hcd.c
2. I make ehci-fsl.c as built-in

Please suggest.
 
> Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/