linux-kernel - Re: [PATCH 2/3] tty: serial: fsl_lpuart: remove RTS/CTS control from set/get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55683B17.1010706@toradex.com>
Date:	Fri, 29 May 2015 15:40:31 +0530
From:	Bhuvanchandra DV <bhuvanchandra.dv@...adex.com>
To:	Jakub Kiciński <moorray3@...pl>
CC:	<gregkh@...uxfoundation.org>, <linux-kernel@...r.kernel.org>,
	<stefan@...er.ch>, <shawn.guo@...aro.org>, <kernel@...gutronix.de>,
	<jslaby@...e.cz>, <linux-serial@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	<devicetree@...r.kernel.org>, <bhuvanchandra.dv@...il.com>
Subject: Re: [PATCH 2/3] tty: serial: fsl_lpuart: remove RTS/CTS control from
 set/get_mctrl

Hello Jakub,

On 05/29/2015 03:34 PM, Jakub Kiciński wrote:
> On Fri, 29 May 2015 13:35:53 +0530, Bhuvanchandra DV wrote:
>> The LPUART does not provide manual control of RTS/CTS signals,
>> those can only be controlled by the hardware directly. Therefore
>> manual control of those signals through mctrl can not be provided.
>> The current implementation enables/disables the automatic control,
>> which is not what mctrl should do, hence remove the incorrect
>> implementation.
>>
>> Signed-off-by: Bhuvanchandra DV <bhuvanchandra.dv@...adex.com>
>
> Now that the functions do nothing there is probably no point in keeping
> separate lpuart/lpuart32 variants.
Agreed, will update it accordingly.

Thanks! for pointing this.
>

Best regards,
Bhuvan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/