linux-kernel - Re: [PATCHv2] ARM: dts: odroidxu3: Enable USB3 regulators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABxcv==n7e2x8wp0tqHzPdfF+RyqWQwkFXTB9_Epy54ZojuhdA@mail.gmail.com>
Date:	Fri, 29 May 2015 15:49:32 +0200
From:	Javier Martinez Canillas <javier@...hile0.org>
To:	Anand Moon <linux.amoon@...il.com>
Cc:	Rob Herring <robh+dt@...nel.org>, Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Russell King <linux@....linux.org.uk>,
	Kukjin Kim <kgene@...nel.org>,
	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-samsung-soc@...r.kernel.org" 
	<linux-samsung-soc@...r.kernel.org>,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCHv2] ARM: dts: odroidxu3: Enable USB3 regulators

Hello Anand,

On Fri, May 29, 2015 at 3:34 PM, Anand Moon <linux.amoon@...il.com> wrote:
> Enable regulator for usbdrd3_0 and usbdrd3_1.
> Looking at the schematic pin diagram for MAX77802
> USB3_0 and USB3_1 is regulated by LDO9 and LD011.
>
> Fix the boot message of failed.
> [    3.503539] exynos-dwc3 usb@...00000: Looking up vdd33-supply from device tree
> [    3.503556] exynos-dwc3 usb@...00000: Looking up vdd33-supply property in node /usb@...00000 failed
> [    3.503568] usb@...00000 supply vdd33 not found, using dummy regulator
> [    3.509154] exynos-dwc3 usb@...00000: Looking up vdd10-supply from device tree
> [    3.509170] exynos-dwc3 usb@...00000: Looking up vdd10-supply property in node /usb@...00000 failed
> [    3.509181] usb@...00000 supply vdd10 not found, using dummy regulator
> [    3.917548] exynos-dwc3 usb@...00000: Looking up vdd33-supply from device tree
> [    3.917565] exynos-dwc3 usb@...00000: Looking up vdd33-supply property in node /usb@...00000 failed
> [    3.917578] usb@...00000 supply vdd33 not found, using dummy regulator
> [    3.922731] exynos-dwc3 usb@...00000: Looking up vdd10-supply from device tree
> [    3.922747] exynos-dwc3 usb@...00000: Looking up vdd10-supply property in node /usb@...00000 failed
>
> ---
> This patch is based on Krzysztof github branch work-next/odroid-xu3-s2mps11-irq.
> v2 - Fixed the comment.
> ---
>
> Tested-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>
> Signed-off-by: Anand Moon <linux.amoon@...il.com>
> ---
>  arch/arm/boot/dts/exynos5422-odroidxu3.dts | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>

Your commit message is again not correct. Sorry if this is a long
explanation but I want you to understand how the git tools work.

What git am and other git tools do is to strip any text that is
between the first "---" and the actual diff. With git format-patch the
information that is placed there by default is the file(s) diffstat
since that is a useful information for someone reviewing your patches
but not so to be part of the commit message, you can get it anyways
later with git $commitId --stat.

So what people do is to add information after the first "---" that is
relevant for reviewers but don't want to end the commit message.
Usually this is the patch change history but it can contain any other
information like links to previous patches, dependencies posted
previously, etc.

With your current patch, that means that git am will strip your
Signed-off-by and Krzysztof's Tested-by tags which should be part of
the commit message.

Krzysztof already mentioned but a good exercise would be to generate
your patch with git format-patch and then apply again with git am to
see if the end result is what you were expecting for.

Hope it helps,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/