linux-kernel - Re: [PATCH 06/15] alpha: don't use module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 29 May 2015 11:15:38 -0400
From:	Paul Gortmaker <paul.gortmaker@...driver.com>
To:	Matt Turner <mattst88@...il.com>
CC:	LKML <linux-kernel@...r.kernel.org>,
	Richard Henderson <rth@...ddle.net>,
	Ivan Kokshaysky <ink@...assic.park.msu.ru>,
	linux-alpha <linux-alpha@...r.kernel.org>
Subject: Re: [PATCH 06/15] alpha: don't use module_init for non-modular core
 code

On 2015-05-29 01:51 AM, Matt Turner wrote:
> On Thu, May 28, 2015 at 5:48 PM, Paul Gortmaker
> <paul.gortmaker@...driver.com> wrote:
>> The srm console is always built in.  It will never be modular,
>> so using module_init as an alias for __initcall is rather
>> misleading.
>>
>> Fix this up now, so that we can relocate module_init from
>> init.h into module.h in the future.  If we don't do this, we'd
>> have to add module.h to obviously non-modular code, and that
>> would be a worse thing.
>>
>> Direct use of __initcall is discouraged, vs prioritized ones.
>> Use of device_initcall is consistent with what __initcall
>> maps onto, and hence does not change the init order, making the
>> impact of this change zero.   Should someone with real hardware
>> for boot testing want to change it later to arch_initcall or
>> console_initcall, they can do that at a later date.
>>
>> Cc: Richard Henderson <rth@...ddle.net>
>> Reviewed-by: Richard Henderson <rth@...ddle.net>
>> Cc: Ivan Kokshaysky <ink@...assic.park.msu.ru>
>> Cc: Matt Turner <mattst88@...il.com>
>> Cc: linux-alpha@...r.kernel.org
>> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>
>> ---
>
> I included this in my pull request to Linus that went upstream
> yesterday. Thanks!

OK, thanks - I'll drop it from here if/when I rebase onto the
4.1-rc6 pending on Sunday.  If I drop it now I'll risk introducing
a bisect failure for alpha, since my current baseline of 4.1-rc5
doesn't have this now-upstream change from the old original series.

Paul.
--

>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/