linux-kernel - Re: [PATCH 1/3] clk: mux: Add regmap support for simple mux

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABuKBe+2xU=wTezgi6c=A1=2phbq+Xtu2ST=ThETt21OVf-P3A@mail.gmail.com>
Date:	Fri, 29 May 2015 17:58:12 +0200
From:	Matthias Brugger <matthias.bgg@...il.com>
To:	Joachim Eastwood <manabian@...il.com>
Cc:	Mike Turquette <mturquette@...aro.org>,
	Stephen Boyd <sboyd@...eaurora.org>,
	HenryC Chen <henryc.chen@...iatek.com>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	James Liao <jamesjj.liao@...iatek.com>,
	Philipp Zabel <p.zabel@...gutronix.de>,
	linux-clk@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"moderated list:ARM/Mediatek SoC..." 
	<linux-mediatek@...ts.infradead.org>
Subject: Re: [PATCH 1/3] clk: mux: Add regmap support for simple mux

2015-05-29 8:57 GMT+02:00 Joachim  Eastwood <manabian@...il.com>:
> Hi Matthias,
>
> On 28 May 2015 at 20:41, Matthias Brugger <matthias.bgg@...il.com> wrote:
>> Some devices like SoCs from Mediatek need to use the clock muxes
>> through a regmap interface.
>> This patch adds regmap support for simple the simple multiplexer
>> clock code.
>
> Nice to see regmap support. This something I would also like to see
> added to the clk framework.
> And if the approach is agreed upon I would like to see support on
> gates and dividers also.

I totally agree.

>
>> +static void clk_mux_writel(struct clk_mux *mux, u32 val)
>> +{
>> +       if (mux->flags && CLK_MUX_USE_REGMAP)
>
> Assume you mean &.

Sure, it's just luck that the patch didn't end up with a hanging
system when I tested it yesterday.
Fixed in next version.

>
>> +               regmap_write(mux->regmap, mux->offset, val);
>> +       else
>> +               clk_writel(val, mux->reg);
>> +}
>> +
>> +static u32 clk_mux_readl(struct clk_mux *mux)
>> +{
>> +       u32 val;
>> +
>> +       if (mux->flags && CLK_MUX_USE_REGMAP)
>
> And here.

Ditto.

>
>> +               regmap_read(mux->regmap, mux->offset, &val);
>> +       else
>> +               val = clk_readl(mux->reg);
>> +
>> +       return val;
>> +}
>> +
> [...]
>> @@ -409,7 +410,9 @@ void clk_unregister_divider(struct clk *clk);
>>  struct clk_mux {
>>         struct clk_hw   hw;
>
>>         void __iomem    *reg;
>> +       struct regmap   *regmap;
>
> Since it not possible to have both iomem and regmap at the same time.
> Could this be put in a union or does that make registration more
> difficult?

It just adds a flag check to the registration.
I will add it in the next version.

Thanks for reviewing.
Matthias


-- 
motzblog.wordpress.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/