linux-kernel - Re: [PATCH] staging: me_daq: use schedule_timeout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55689582.1000700@mev.co.uk>
Date:	Fri, 29 May 2015 17:36:18 +0100
From:	Ian Abbott <abbotti@....co.uk>
To:	Nicholas Mc Guire <hofrat@...dl.org>
CC:	H Hartley Sweeten <hsweeten@...ionengravers.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Davidlohr Bueso <dave@...olabs.net>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: me_daq: use schedule_timeout_interruptible()

On 29/05/15 16:58, Nicholas Mc Guire wrote:
> API consolidation with coccinelle found:
> ./drivers/staging/comedi/drivers/me_daq.c:177:1-17:
>          consolidation with schedule_timeout_*() recommended
>
> This is a 1:1 conversion of the current calls to an available helper
> only - so only an API consolidation to improve readability.
>
> Patch was compile tested with x86_64_defconfig + CONFIG_STAGING=y,
> CONFIG_COMEDI=y, CONFIG_COMEDI_PCI_DRIVERS=y CONFIG_COMEDI_ME_DAQ=m
>
> Patch is against 4.1-rc5 (localversion-next is -next-20150529)

Minor niggle: you don't really need to say what version the patch is 
against in the commit message, as the version will have changed by the 
time the patch is committed.  It can be mentioned after the "---" marker 
line if relevant, as the stuff after the "---" line does not end up in 
the commit message.

>
> Signed-off-by: Nicholas Mc Guire <hofrat@...dl.org>
> ---
>   drivers/staging/comedi/drivers/me_daq.c |    3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/me_daq.c b/drivers/staging/comedi/drivers/me_daq.c
> index d78e919..9ea1ba4 100644
> --- a/drivers/staging/comedi/drivers/me_daq.c
> +++ b/drivers/staging/comedi/drivers/me_daq.c
> @@ -173,8 +173,7 @@ struct me_private_data {
>
>   static inline void sleep(unsigned sec)
>   {
> -	__set_current_state(TASK_INTERRUPTIBLE);
> -	schedule_timeout(sec * HZ);
> +	schedule_timeout_interruptible(sec * HZ);
>   }
>
>   static int me_dio_insn_config(struct comedi_device *dev,
>

The patch itself looks fine!

Reviewed-by: Ian Abbott <abbotti@....co.uk>

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/