linux-kernel - Re: [PATCH 2/2] staging: dgnc: switch timeout to signed type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 29 May 2015 20:05:22 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Nicholas Mc Guire <hofrat@...dl.org>
Cc:	Lidza Louina <lidza.louina@...il.com>, devel@...verdev.osuosl.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	driverdev-devel@...uxdriverproject.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] staging: dgnc: switch timeout to signed type

On Fri, May 29, 2015 at 06:41:28PM +0200, Nicholas Mc Guire wrote:
> The schedule_timeout*() helpers take the timeout as signed long, as
> ch_close_delay in struct channel_t was not used for other purposes its
> type was switched to signed long and the declarations fixed up.

Uh, we never pass it to schedule_timeout etc and even if we did how
would that matter?  It's either 250 or 0.

What is the bug you are trying to fix and we can help you?

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/