linux-kernel - Re: [PATCH] mtd: use cfi-util in jedecprobe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150529170818.GU27753@ld-irv-0074>
Date:	Fri, 29 May 2015 10:08:18 -0700
From:	Brian Norris <computersforpeace@...il.com>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Denys Vlasenko <dvlasenk@...hat.com>,
	linux-mtd@...ts.infradead.org,
	Dan Carpenter <dan.carpenter@...cle.com>,
	David Woodhouse <David.Woodhouse@...el.com>,
	Artem Bityutskiy <Artem.Bityutskiy@...ux.intel.com>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mtd: use cfi-util in jedecprobe

Hi Arnd,

On Fri, May 29, 2015 at 10:39:28AM +0200, Arnd Bergmann wrote:
> A recent change to move cfi helper functions out of line
> is causing build errors when cfi-util is a loadable module
> and jedecprobe is built-in:
> 
> drivers/built-in.o: In function `jedec_reset':
> (.text+0x140694): undefined reference to `cfi_send_gen_cmd'
> drivers/built-in.o: In function `jedec_probe_chip':
> (.text+0x140794): undefined reference to `cfi_build_cmd_addr'
> 
> This adds a 'select' for the module containing these functions
> from the jedecprobe code, to ensure it is always reachable.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Fixes: 4612c715a6ea6 ("mtd: cfi: deinline large functions")

Already caught and fixed:

http://patchwork.ozlabs.org/patch/477464/

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/