linux-kernel - Re: [PATCH] PM / Wakeirq: Fix typo in prototype for dev_pm_set_dedicated_wake

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150529171837.GI2026@saruman.tx.rr.com>
Date:	Fri, 29 May 2015 12:18:37 -0500
From:	Felipe Balbi <balbi@...com>
To:	Tony Lindgren <tony@...mide.com>
CC:	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
	Alan Stern <stern@...land.harvard.edu>,
	Andreas Fenkart <afenkart@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Felipe Balbi <balbi@...com>,
	Huiquan Zhong <huiquan.zhong@...el.com>,
	Kevin Hilman <khilman@...nel.org>, NeilBrown <neilb@...e.de>,
	Mika Westerberg <mika.westerberg@...ux.intel.com>,
	Nishanth Menon <nm@...com>,
	Peter Hurley <peter@...leysoftware.com>,
	Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
	Ulf Hansson <ulf.hansson@...aro.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	<linux-pm@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-serial@...r.kernel.org>, <linux-omap@...r.kernel.org>,
	Stephen Rothwell <sfr@...b.auug.org.au>
Subject: Re: [PATCH] PM / Wakeirq: Fix typo in prototype for
 dev_pm_set_dedicated_wake_irq

On Fri, May 29, 2015 at 09:54:02AM -0700, Tony Lindgren wrote:
> Looks like I only built test the dev_pm_set_wake_irq and not the
> dev_pm_set_dedicated_wake_irq case on x86.
> 
> Turns out there's a typo for the dev_pm_set_dedicated_wake_irq
> prototype that causes a build error if CONFIG_COMPILE_TEST
> and CONFIG_MMC_OMAP_HS are selected.
> 
> Cc: Stephen Rothwell <sfr@...b.auug.org.au>
> Cc: Ulf Hansson <ulf.hansson@...aro.org>
> Reported-by: Jim Davis <jim.epost@...il.com>
> Signed-off-by: Tony Lindgren <tony@...mide.com>

cool:

Reviewed-by: Felipe Balbi <balbi@...com>

> ---
>  include/linux/pm_wakeirq.h | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/include/linux/pm_wakeirq.h b/include/linux/pm_wakeirq.h
> index 4046fa1..cd5b62d 100644
> --- a/include/linux/pm_wakeirq.h
> +++ b/include/linux/pm_wakeirq.h
> @@ -30,8 +30,7 @@ static inline int dev_pm_set_wake_irq(struct device *dev, int irq)
>  	return 0;
>  }
>  
> -static inline int dev_pm_set_dedicated__wake_irq(struct device *dev,
> -						 int irq)
> +static inline int dev_pm_set_dedicated_wake_irq(struct device *dev, int irq)
>  {
>  	return 0;
>  }
> -- 
> 2.1.4
> 

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)