linux-kernel - Re: [PATCH 6/6] edac, mce_amd_inj: Inject errors on NBC for bank 4 errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150529192303.GS31435@pd.tnic>
Date:	Fri, 29 May 2015 21:23:03 +0200
From:	Borislav Petkov <bp@...en8.de>
To:	Aravind Gopalakrishnan <aravind.gopalakrishnan@....com>
Cc:	dougthompson@...ssion.com, mchehab@....samsung.com,
	linux-edac@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 6/6] edac, mce_amd_inj: Inject errors on NBC for bank 4
 errors

On Fri, May 29, 2015 at 01:52:32PM -0500, Aravind Gopalakrishnan wrote:
> Yeah, I do run checkpatch. With this, I think the line was going above 79
> chars. So split it.

Yeah, don't take checkpatch too seriously - only as a hint. Common sense
should be employed, instead. :)

> I thought we split such error messages right?

Right, so string error messages we do not split for easier grepping.

> (amd64_edac and mce_amd.c for example have such instances)

Yeah, those will have to be fixed gradually when we're touching the code
anyway, at some point.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/