[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20150529194955.GV2026@saruman.tx.rr.com>
Date: Fri, 29 May 2015 14:49:55 -0500
From: Felipe Balbi <balbi@...com>
To: Pavel Machek <pavel@....cz>
CC: Sebastian Reichel <sre@...nel.org>,
kernel list <linux-kernel@...r.kernel.org>,
<maxime.ripard@...e-electrons.com>, <dmitry.torokhov@...il.com>,
<pali.rohar@...il.com>, <sre@...ian.org>, <sre@...g0.de>,
linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
<linux-omap@...r.kernel.org>, <tony@...mide.com>,
<khilman@...nel.org>, <aaro.koskinen@....fi>,
<ivo.g.dimitrov.75@...il.com>, <patrikbachan@...il.com>
Subject: Re: [PATCH] fix n900 dts file to work around 4.1 touchscreen
regression on n900
Hi,
On Fri, May 29, 2015 at 09:32:11PM +0200, Pavel Machek wrote:
> Fix dts to match what the Linux kernel expects. This works around
> touchscreen problems in 4.1 linux on Nokia n900.
>
> Signed-off-by: Pavel Machek <pavel@....cz>
>
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/tsc2005.txt b/Documentation/devicetree/bindings/input/touchscreen/tsc2005.txt
> index 4b641c7..09089a6 100644
> --- a/Documentation/devicetree/bindings/input/touchscreen/tsc2005.txt
> +++ b/Documentation/devicetree/bindings/input/touchscreen/tsc2005.txt
> @@ -32,8 +32,8 @@ Example:
> touchscreen-fuzz-x = <4>;
> touchscreen-fuzz-y = <7>;
> touchscreen-fuzz-pressure = <2>;
> - touchscreen-max-x = <4096>;
> - touchscreen-max-y = <4096>;
> + touchscreen-size-x = <4096>;
> + touchscreen-size-y = <4096>;
IMHO, the older binding needs to be supported as well. It's fine to
update the DTS for the new binding, but even Documentation says
touchscreen-max-[xy] and if the driver changed that, the driver should
be fixed too. Besides, it seems like this has been in tree since v3.16:
$ git describe a38cfebb56898633687ab337fd53710e63a0aedd
v3.15-rc5-72-ga38cfebb5689
So, because this has been wrongly documented for so long, we should
support both bindings. Sure, deprecate touchscreen-max-[xy], but they
must still be supported, IMO.
In any case, for this patch:
Reviewed-by: Felipe Balbi <balbi@...com>
--
balbi
Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)
Powered by blists - more mailing lists