linux-kernel - Re: [PATCH] zpool: add EXPORT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 29 May 2015 14:37:20 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Dan Streetman <ddstreet@...e.org>
Cc:	Christoph Hellwig <hch@...radead.org>,
	Minchan Kim <minchan@...nel.org>,
	Ganesh Mahendran <opensource.ganesh@...il.com>,
	Kees Cook <keescook@...omium.org>,
	Linux-MM <linux-mm@...ck.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] zpool: add EXPORT_SYMBOL for functions

On Fri, 29 May 2015 12:35:46 -0400 Dan Streetman <ddstreet@...e.org> wrote:

> On Fri, May 29, 2015 at 12:30 PM, Christoph Hellwig <hch@...radead.org> wrote:
> > On Fri, May 29, 2015 at 11:36:05AM -0400, Dan Streetman wrote:
> >> because they are available for public use, per zpool.h?  If, e.g.,
> >> zram ever started using zpool, it would need them exported, wouldn't
> >> it?
> >
> > If you want to use it in ram export it in the same series as those
> > changes, and explain what the exprots are for in your message body.
> >
> 
> I don't want to use it in zram.  I wrote zpool, but neglected to
> export the functions.  They should be exported though.
> 
> What's your reasoning for not wanting them exported?

It's just noise which has no value.  Adding exports when there is a
demonstrated need is an OK approach.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/