linux-kernel - Re: [PATCH v8 6/7] clk: hi6220: Clock driver support for Hisilicon hi6220 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5567D02C.1070209@huawei.com>
Date:	Fri, 29 May 2015 10:34:20 +0800
From:	Bintian <bintian.wang@...wei.com>
To:	Michael Turquette <mturquette@...aro.org>,
	Kevin Hilman <khilman@...nel.org>
CC:	<sboyd@...eaurora.org>, <zhangfei.gao@...aro.org>,
	<xuwei5@...ilicon.com>, <xuejiancheng@...wei.com>,
	<tomeu.vizoso@...labora.com>, <sledge.yanwei@...wei.com>,
	<linux-clk@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<arnd@...db.de>, <will.deacon@....com>, <robh+dt@...nel.org>,
	<mark.rutland@....com>, <catalin.marinas@....com>,
	<haojian.zhuang@...aro.org>,
	<linux-arm-kernel@...ts.infradead.org>, <olof@...om.net>,
	<yanhaifeng@...il.com>, <linux@....linux.org.uk>,
	<guodong.xu@...aro.org>, <jorge.ramirez-ortiz@...aro.org>,
	<tyler.baker@...aro.org>, <xuyiping@...ilicon.com>,
	<wangbinghui@...ilicon.com>, <zhenwei.wang@...ilicon.com>,
	<victor.lixin@...ilicon.com>, <puck.chen@...ilicon.com>,
	<dan.zhao@...ilicon.com>, <huxinwei@...wei.com>,
	<z.liuxinliang@...wei.com>, <heyunlei@...wei.com>,
	<kong.kongxinwei@...ilicon.com>, <wangbintian@...il.com>,
	<w.f@...wei.com>, <liguozhu@...ilicon.com>
Subject: Re: [PATCH v8 6/7] clk: hi6220: Clock driver support for Hisilicon
 hi6220 SoC

Hello Mike,

On 2015/5/29 9:07, Michael Turquette wrote:
> Quoting Kevin Hilman (2015-05-28 10:32:05)
>> Bintian <bintian.wang@...wei.com> writes:
>>
>>> Hello Mike,
>>>
>>> On 2015/5/28 13:26, Michael Turquette wrote:
>>>> Quoting Bintian Wang (2015-05-23 21:11:11)
>>>>> Add clock drivers for hi6220 SoC, this driver controls the SoC
>>>>> registers to supply different clocks to different IPs in the SoC.
>>>>>
>>>>> We add one divider clock for hi6220 because the divider in hi6220
>>>>> also has a mask bit but it doesnot obey the rule defined by flag
>>>>> "CLK_DIVIDER_HIWORD_MASK", we can not get index of the mask bit by
>>>>> left shift fixed bits (e.g. 16 bits), so we add this divider clock
>>>>> to handle it.
>>>>>
>>>>> Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@...aro.org>
>>>>> Signed-off-by: Bintian Wang <bintian.wang@...wei.com>
>>>>> Acked-by: Haojian Zhuang <haojian.zhuang@...aro.org>
>>>>> Reviewed-by: Zhangfei Gao <zhangfei.gao@...aro.org>
>>>>> Tested-by: Will Deacon <will.deacon@....com>
>>>>> Tested-by: Tyler Baker <tyler.baker@...aro.org>
>>>>
>>>> Hi Bintian,
>>>>
>>>> Thanks for making the changes requested by Stephen. I've taken his patch
>>>> to add assigned-clock-rate/parent support for AMBA interconnects and
>>>> applied it to 4.1-rc1, and then I've applied your v8 patches #4-6 on top
>>>> of that. You can find it at:
>>>>
>>>> git://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next-hi6220
>>> Thank you very much!
>>>
>>> I think you also need to pick patch "[PATCH v5 3/6] clk: hi6220:
>>> Document devicetree bindings for hi6220 clock",  which described the
>>> dt binding of clk, and it is also acked by Stephen(v4 is the same to
>>> v5).
>>>
>>>> I have merged this into clk-next so it can get some cycles in
>>>> linux-next.
>>>>
>>>> Stephen,
>>>>
>>>> Can you send your patch out to Russell properly? It needs his ack (or
>>>> for him to take it outright) in order to unblock the hi6220 clock driver
>>>> from being merged.
>>> It doesn't block hi6220 clock driver now, because the UART1 is not
>>> enabled in hi6220 dts now.
>>
>> Now that the clk changes are queued up, can you (re)post the remaining
>> hikey patches with a changelog stating the dependency on the clk-next
>> branch.  I believe what's left is just the DT and Kconfig/defconfig
>> changes, correct?
>
> Just to be clear, clk-next-hi6220 is not an immutable branch. I just put
> it up to get some testing done on it. Depending on whether or not
> Russell acks Stephen's patch then it may be changed.
Stephen's patch can help UART1 to switch to the higher clock, so we can
remove the "clk_set_parent" from the "clk-hi6220.c" safely and don't
need to do that workaround in advance.

You know, we don't enable the UART1 in this series, and we can submit
other patch to enable it after Stephen's patch is merged.

Thanks,

Bintian

>
> Regards,
> Mike
>
>>
>> With some acks from the DT maintainers, these should be ready to be
>> merged through arm-soc.
>>
>> Thanks,
>>
>> Kevin
>
> .
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/