linux-kernel - Re: [PATCH] Staging: lustre: fix style issues in dt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 30 May 2015 17:35:33 +0200 (CEST)
From:	Julia Lawall <julia.lawall@...6.fr>
To:	Zoltán Lajos Kis <zoltan.lajos.kis@...il.com>
cc:	oleg.drokin@...el.com, andreas.dilger@...el.com,
	gregkh@...uxfoundation.org, Julia.Lawall@...6.fr,
	kumari.radha3@...il.com, mahfouz.saif.elyazal@...il.com,
	gdonald@...il.com, HPDD-discuss@...1.01.org,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: lustre: fix style issues in dt_object.c

On Sat, 30 May 2015, Zoltán Lajos Kis wrote:

> Fixes coding style issues for lustre/lustre/odbclass/dt_object.c that
> were found by the checkpatch.pl tool.
>
> Signed-off-by: Zoltán Lajos Kis <zoltan.lajos.kis@...il.com>
>
> ---
> ---

Only one --- is needed.

It is better for a patch to do only one thing.  This one does a bunch of
unrelated things (except for the checkpatch connection).

julia

>  drivers/staging/lustre/lustre/obdclass/dt_object.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/lustre/lustre/obdclass/dt_object.c b/drivers/staging/lustre/lustre/obdclass/dt_object.c
> index b1eee0a..91fd7b9 100644
> --- a/drivers/staging/lustre/lustre/obdclass/dt_object.c
> +++ b/drivers/staging/lustre/lustre/obdclass/dt_object.c
> @@ -237,7 +237,8 @@ EXPORT_SYMBOL(dt_locate_at);
>  /**
>   * find a object named \a entry in given \a dfh->dfh_o directory.
>   */
> -static int dt_find_entry(const struct lu_env *env, const char *entry, void *data)
> +static int dt_find_entry(const struct lu_env *env,
> +			 const char *entry, void *data)
>  {
>  	struct dt_find_hint  *dfh = data;
>  	struct dt_device     *dt = dfh->dfh_dt;
> @@ -330,9 +331,9 @@ static struct dt_object *dt_reg_open(const struct lu_env *env,
>  	int result;
>
>  	result = dt_lookup_dir(env, p, name, fid);
> -	if (result == 0){
> +	if (result == 0)
>  		o = dt_locate(env, dt, fid);
> -	} else
> +	else
>  		o = ERR_PTR(result);
>
>  	return o;
> @@ -528,7 +529,6 @@ void dt_version_set(const struct lu_env *env, struct dt_object *o,
>  	rc = dt_xattr_set(env, o, &vbuf, xname, 0, th, BYPASS_CAPA);
>  	if (rc < 0)
>  		CDEBUG(D_INODE, "Can't set version, rc %d\n", rc);
> -	return;
>  }
>  EXPORT_SYMBOL(dt_version_set);
>
> @@ -923,7 +923,7 @@ int dt_index_read(const struct lu_env *env, struct dt_device *dev,
>  	ii->ii_version = dt_version_get(env, obj);
>
>  	/* walk the index and fill lu_idxpages with key/record pairs */
> -	rc = dt_index_walk(env, obj, rdpg, dt_index_page_build ,ii);
> +	rc = dt_index_walk(env, obj, rdpg, dt_index_page_build, ii);
>  	dt_read_unlock(env, obj);
>
>  	if (rc == 0) {
> @@ -939,7 +939,7 @@ out:
>  }
>  EXPORT_SYMBOL(dt_index_read);
>
> -#if defined (CONFIG_PROC_FS)
> +#if defined(CONFIG_PROC_FS)
>
>  int lprocfs_dt_rd_blksize(char *page, char **start, off_t off,
>  			  int count, int *eof, void *data)
> --
> 1.9.1
>
>