linux-kernel - Re: [PATCH 43/98] include/uapi/linux/hdlc/ioctl.h: include linux/if.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150530202253.GD15645@bugger.home>
Date:	Sat, 30 May 2015 22:22:53 +0200
From:	Frans Klaver <fransklaver@...il.com>
To:	Mikko Rapeli <mikko.rapeli@....fi>
Cc:	linux-kernel@...r.kernel.org, linux-api@...r.kernel.org
Subject: Re: [PATCH 43/98] include/uapi/linux/hdlc/ioctl.h: include linux/if.h

On Sat, May 30, 2015 at 05:38:35PM +0200, Mikko Rapeli wrote:
> Fixes userspace compiler error:
> 
> error: ‘IFNAMSIZ’ undeclared here (not in a function)
> 
> Signed-off-by: Mikko Rapeli <mikko.rapeli@....fi>
> ---
>  include/uapi/linux/hdlc/ioctl.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/uapi/linux/hdlc/ioctl.h b/include/uapi/linux/hdlc/ioctl.h
> index 04bc027..8bbee11 100644
> --- a/include/uapi/linux/hdlc/ioctl.h
> +++ b/include/uapi/linux/hdlc/ioctl.h
> @@ -1,6 +1,7 @@
>  #ifndef __HDLC_IOCTL_H__
>  #define __HDLC_IOCTL_H__
>  
> +#include <linux/if.h>
>  
>  #define GENERIC_HDLC_VERSION 4	/* For synchronization with sethdlc utility */

What's the point of this one if you break this circular dependency in
patch 49? Are those in between related?

Thanks,
Frans
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/