linux-kernel - Re: [rtc-linux] [PATCH] rtc: snvs: fix wakealarm by call enable_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150530205303.GJ2185@piout.net>
Date:	Sat, 30 May 2015 22:53:03 +0200
From:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>
To:	Stefan Agner <stefan@...er.ch>
Cc:	a.zummo@...ertech.it, maitysanchayan@...il.com,
	shawn.guo@...aro.org, rtc-linux@...glegroups.com,
	linux-kernel@...r.kernel.org
Subject: Re: [rtc-linux] [PATCH] rtc: snvs: fix wakealarm by call
 enable_irq_wake earlier

Hi,

On 21/05/2015 at 17:29:35 +0200, Stefan Agner wrote :
> When entering suspend while an wakeup alarm is set, enable_set_wake
> should make sure that the RTC interrupt keep being enabled and the
> .irq_set_wake for the RTC interrupt get called. However, since the
> driver uses the suspend_noirq callback, the call to enable_irq_wake
> has been made after disabling the interrupts. While .irq_set_wake
> has been called properly, the interrupt remained disabled.
> 
> Use the suspend callback to call enable_irq_wake early enough to
> ensure the RTC interrupt remains enabled.
> 
> Fixes: 7654e9d4fd8f ("drivers/rtc/rtc-snvs: fix suspend/resume")
> Signed-off-by: Stefan Agner <stefan@...er.ch>

I'm applying it after adding
Cc:  <stable@...r.kernel.org> # 3.19

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/