linux-kernel - Re: [rtc-linux] Re: [PATCH v2] rtc: pcf8563 fix: return -EINVAL if we read an invalid time.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150530222142.GM2185@piout.net>
Date:	Sun, 31 May 2015 00:21:42 +0200
From:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>
To:	Richard Weinberger <richard.weinberger@...il.com>
Cc:	Jan Kardell <jan.kardell@...liq.com>,
	Alessandro Zummo <a.zummo@...ertech.it>,
	rtc-linux@...glegroups.com, LKML <linux-kernel@...r.kernel.org>,
	Vincent Donnefort <vdonnefort@...il.com>,
	Dan Carpenter <dan.carpenter@...cle.com>, oen@...liq.com
Subject: Re: [rtc-linux] Re: [PATCH v2] rtc: pcf8563 fix: return -EINVAL if
 we read an invalid time.

On 31/05/2015 at 00:16:39 +0200, Richard Weinberger wrote :
> On Wed, May 27, 2015 at 2:48 PM, Jan Kardell <jan.kardell@...liq.com> wrote:
> > Return -EINVAL if the voltage low bit is set to avoid getting a bogus
> > time at boot.
> > There was a comment stating that util-linux hwclock refuses to set a
> > new time if we return an error code on read, but at least the current
> > version do set the time as expected. Remove the comment and the check
> > for valid time, and let the rtc core check it for us.
> >
> > Changes in v2: Remove the test for invalid time. Change dev_err to
> > dev_info when voltage low is set.
> >
> > Signed-off-by: Jan Kardell <jan.kardell@...liq.com>
> > ---
> >  drivers/rtc/rtc-pcf8563.c | 9 ++-------
> >  1 file changed, 2 insertions(+), 7 deletions(-)
> >
> > diff --git a/drivers/rtc/rtc-pcf8563.c b/drivers/rtc/rtc-pcf8563.c
> > index 0ba7e59..6ce0a86 100644
> > --- a/drivers/rtc/rtc-pcf8563.c
> > +++ b/drivers/rtc/rtc-pcf8563.c
> > @@ -22,7 +22,7 @@
> >  #include <linux/of.h>
> >  #include <linux/err.h>
> >
> > -#define DRV_VERSION "0.4.3"
> > +#define DRV_VERSION "0.4.4"
> 
> Why do you need that?
> Isn't the kernel version enough? :)
> 

That's also what I'm thinking but I don't care enough to ask people to
remove those.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/