linux-kernel - Re: [PATCH V2 3/3] Drivers: hv: vmbus: Allocate ring buffer memory in NUMA aware fashion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150531064114.GB7057@kroah.com>
Date:	Sun, 31 May 2015 15:41:14 +0900
From:	Greg KH <gregkh@...uxfoundation.org>
To:	"K. Y. Srinivasan" <kys@...rosoft.com>
Cc:	linux-kernel@...r.kernel.org, devel@...uxdriverproject.org,
	olaf@...fle.de, apw@...onical.com, vkuznets@...hat.com,
	jasowang@...hat.com
Subject: Re: [PATCH V2 3/3] Drivers: hv: vmbus: Allocate ring buffer memory
 in NUMA aware fashion

On Sat, May 30, 2015 at 11:37:49PM -0700, K. Y. Srinivasan wrote:
> Allocate ring buffer memory from the NUMA node assigned to the channel.

But you do more than just that.  If there's a failure, you fall-back to
the old allocation method.  Why not mention that as well?

And is that what you really want?  Do we ever fail allocation for a node
but still have memory from another one?  Shouldn't the logic be in the
allocator and not be forced to be in every caller?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/