linux-kernel - Re: [PATCH v11 2/12] x86, mm, pat: Refactor !pat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150531094655.GA20440@pd.tnic>
Date:	Sun, 31 May 2015 11:46:55 +0200
From:	Borislav Petkov <bp@...en8.de>
To:	Toshi Kani <toshi.kani@...com>
Cc:	hpa@...or.com, tglx@...utronix.de, mingo@...hat.com,
	akpm@...ux-foundation.org, arnd@...db.de, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org, x86@...nel.org,
	linux-nvdimm@...ts.01.org, jgross@...e.com,
	stefan.bader@...onical.com, luto@...capital.net, hmh@....eng.br,
	yigal@...xistor.com, konrad.wilk@...cle.com, Elliott@...com,
	mcgrof@...e.com, hch@....de
Subject: Re: [PATCH v11 2/12] x86, mm, pat: Refactor !pat_enabled handling

On Fri, May 29, 2015 at 04:59:00PM -0600, Toshi Kani wrote:
> From: Toshi Kani <toshi.kani@...com>
> 
> This patch refactors the !pat_enabled code paths and integrates
> them into the PAT abstraction code.  The PAT table is emulated by
> corresponding to the two cache attribute bits, PWT (Write Through)
> and PCD (Cache Disable).  The emulated PAT table is the same as the
> BIOS default setup when the system has PAT but the "nopat" boot
> option is specified.  The emulated PAT table is also used when
> MSR_IA32_CR_PAT returns 0 -- 9d34cfdf4796 ("x86: Don't rely on
> VMWare emulating PAT MSR correctly").

To be honest, I wasn't surprised when you sent me the same patch and
ignored most of my comments. For the future, please let me know if I'm
wasting my time with commenting on your stuff so that I can plan my work
and not waste time and energy reviewing, ok?

Unfortunately, if you want something done right, you have to do it
yourself.

So I did that, I split that ugly cleanup into something much more
readable, patches as a reply to this message.

Feel free to base your work ontop of

git://git.kernel.org/pub/scm/linux/kernel/git/bp/bp.git#tip-mm-2

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/