[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <556B2E72.5020508@redhat.com>
Date: Sun, 31 May 2015 17:53:22 +0200
From: Hans de Goede <hdegoede@...hat.com>
To: Roman Volkov <rvolkov@...os.org>,
Dmitry Torokhov <dmitry.torokhov@...il.com>
CC: Mark Rutland <mark.rutland@....com>,
Rob Herring <robh+dt@...nel.org>,
Pawel Moll <Pawel.Moll@....com>,
Ian Campbell <ijc+devicetree@...lion.org.uk>,
Kumar Gala <galak@...eaurora.org>,
"grant.likely@...aro.org" <grant.likely@...aro.org>,
Jiri Kosina <jkosina@...e.cz>,
Wolfram Sang <wsa@...-dreams.de>,
"linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
Tony Prisk <linux@...sktech.co.nz>
Subject: Re:
Hi Roman,
On 31-05-15 17:37, Roman Volkov wrote:
> В Sat, 14 Mar 2015 20:20:38 -0700
> Dmitry Torokhov <dmitry.torokhov@...il.com> wrote:
>
>>
>> Hi Roman,
>>
>> On Mon, Feb 16, 2015 at 12:11:43AM +0300, Roman Volkov wrote:
>>> Documentation for 'intel,8042' DT compatible node.
>>>
>>> Signed-off-by: Tony Prisk <linux@...sktech.co.nz>
>>> Signed-off-by: Roman Volkov <v1ron@...os.org>
>>> ---
>>> .../devicetree/bindings/input/intel-8042.txt | 26
>>> ++++++++++++++++++++++ 1 file changed, 26 insertions(+)
>>> create mode 100644
>>> Documentation/devicetree/bindings/input/intel-8042.txt
>>>
>>> diff --git a/Documentation/devicetree/bindings/input/intel-8042.txt
>>> b/Documentation/devicetree/bindings/input/intel-8042.txt new file
>>> mode 100644 index 0000000..ab8a3e0
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/input/intel-8042.txt
>>> @@ -0,0 +1,26 @@
>>> +Intel 8042 Keyboard Controller
>>> +
>>> +Required properties:
>>> +- compatible: should be "intel,8042"
>>> +- regs: memory for keyboard controller
>>> +- interrupts: usually, two interrupts should be specified
>>> (keyboard and aux).
>>> + However, only one interrupt is also allowed in case of
>>> absence of the
>>> + physical port in the controller. The i8042 driver must be
>>> loaded with
>>> + nokbd/noaux option in this case.
>>> +- interrupt-names: interrupt names corresponding to numbers in the
>>> list.
>>> + "kbd" is the keyboard interrupt and "aux" is the auxiliary
>>> (mouse)
>>> + interrupt.
>>> +- command-reg: offset in memory for command register
>>> +- status-reg: offset in memory for status register
>>> +- data-reg: offset in memory for data register
>>> +
>>> +Example:
>>> + i8042@...08800 {
>>> + compatible = "intel,8042";
>>> + regs = <0xd8008800 0x100>;
>>> + interrupts = <23>, <4>;
>>> + interrupt-names = "kbd", "aux";
>>> + command-reg = <0x04>;
>>> + status-reg = <0x04>;
>>> + data-reg = <0x00>;
>>> + };
>>
>> No, we already have existing OF bindings for i8042 on sparc and
>> powerpc, I do not think we need to invent a brand new one.
>>
>> Thanks.
>>
>
> Hi Dmitry,
>
> I see some OF code in i8042-sparcio.h file. There are node definitions
> like "kb_ps2", "keyboard", "kdmouse", "mouse". Are these documented
> somewhere?
>
> Great if vt8500 is not unique with OF bindings for i8042. The code from
> sparc even looks compatible, only register offsets are hardcoded for
> specific machine. Is it possible to read offsets from Device Tree using
> these existing bindings without dealing with the kernel configuration?
Have you looked at the existing bindings for ps/2 controllers
under Documentation/devicetree/bindings/serio ?
Regards,
Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists