linux-kernel - Re: [PATCH 1/2] staging: wilc1000: Fix some compile warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150530235941.GB20036@kroah.com>
Date:	Sun, 31 May 2015 08:59:41 +0900
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Stanislav Kholmanskikh <kholmanskikh.s.s@...il.com>
Cc:	johnny.kim@...el.com, rachel.kim@...el.com, dean.lee@...el.com,
	chris.park@...el.com, devel@...verdev.osuosl.org,
	linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] staging: wilc1000: Fix some compile warnings

On Sat, May 30, 2015 at 11:44:18PM +0300, Stanislav Kholmanskikh wrote:
> This patch reduces (a little bit) the amount of compile time
> warnings.
> 
> The change of WILC_WFI_init_mon_interface() prototype seems to be ok,
> because alloc_netdev() also expects 'const char *name'.

You are doing different types of fixes here, please be explicit about
what you are doing and break this up into logical patches that each only
do one type of thing.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/